Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: Expose only the cluster-info ConfigMap in the kube-public ns #48050

Merged
merged 1 commit into from
Jun 28, 2017
Merged

kubeadm: Expose only the cluster-info ConfigMap in the kube-public ns #48050

merged 1 commit into from
Jun 28, 2017

Conversation

luxas
Copy link
Member

@luxas luxas commented Jun 26, 2017 •
edited by enisoc

What this PR does / why we need it:

Noticed a bug; we should only expose the cluster-info ConfigMap.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Fixes: kubernetes/kubeadm#320

Special notes for your reviewer:

Cherrypick-candidate for v1.8 cc @dchen1107
Not blocking the release though...

Release note:

@jbeda @pipejakob @timothysc @kubernetes/sig-cluster-lifecycle-pr-reviews

@luxas luxas added approved-for-milestone area/security kind/bug Categorizes issue or PR as related to a bug. labels Jun 26, 2017
@luxas luxas added this to the v1.7 milestone Jun 26, 2017
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 26, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Jun 26, 2017
@luxas luxas mentioned this pull request Jun 26, 2017
Closed
@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2017
@timothysc
Copy link
Member

/lgtm but In order for it to get into 1.7 you need to talk with @kubernetes/sig-release-misc

@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Jun 27, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: luxas, timothysc

Associated issue: 320

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@caesarxuchao
Copy link
Member

Looks right. I'll approve the cherrypick. cc @dchen1107.

@caesarxuchao caesarxuchao added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 27, 2017
@luxas
Copy link
Member Author

luxas commented Jun 28, 2017

Got lgtm and was approved by the release team. Adding the label

@luxas luxas added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 28, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 6089557 into kubernetes:master Jun 28, 2017
@luxas
Copy link
Member Author

luxas commented Jun 29, 2017

@caesarxuchao Did this get cherrypicked?

@caesarxuchao
Copy link
Member

caesarxuchao commented Jun 29, 2017 •
edited

Sorry, no. Somehow i missed this one in the batch cherrypick. 1.7.1 ok?

@luxas
Copy link
Member Author

luxas commented Jun 29, 2017

@caesarxuchao Let's do it by "best effort". If you still cherrypick, include, if not, v1.7.1 is fine.
Security patch but was in v1.6 as well...

@luxas luxas mentioned this pull request Jun 30, 2017
Merged
@enisoc enisoc added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 30, 2017
@luxas luxas mentioned this pull request Jun 30, 2017
Closed
@caesarxuchao caesarxuchao mentioned this pull request Jun 30, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Jul 1, 2017
Merge pull request #48355 from luxas/automated-cherry-pick-of-#48050-…
5d144c0 
…upstream-release-1.6

Automatic merge from submit-queue

Automated cherry pick of #48050

Cherry pick of #48050 on release-1.6.

#48050: kubeadm: Expose only the cluster-info ConfigMap in the
k8s-github-robot pushed a commit that referenced this pull request Jul 6, 2017
Merge pull request #48364 from caesarxuchao/automated-cherry-pick-of-…
adf575e 
…#47875-#48050-#48261-upstream-release-1.7

Automatic merge from submit-queue

Automated cherry pick of #47875 #48050 #48261

Cherry pick of #47875 #48050 #48261 on release-1.7.

#47875: Implement e2e test for Stackdriver event exporter
#48050: kubeadm: Expose only the cluster-info ConfigMap in the
#48261: Fix removing finalizer for garbage collector
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jbeda jbeda

@timothysc timothysc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/security cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

Only the cluster-info ConfigMap should be exposed in the kube-public namespace
8 participants
@luxas @timothysc @k8s-github-robot @caesarxuchao @k8s-cherrypick-bot @jbeda @enisoc @k8s-ci-robot